This repository was archived by the owner on Jan 22, 2024. It is now read-only.
Make connection handling more explicit and remove outdated examples #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch we can be more certain that the connection is not kept for longer than the `read_timeout`.
Refer to https://developer.geops.io for up to date documentation.
aheld84
reviewed
Feb 22, 2023
Member
aheld84
left a comment
aheld84
left a comment
There was a problem hiding this comment.
There are two points that need clarification. Otherwise it looks good.
This deprecates the `read_timeout` argument but does not brake the existing public API. Also switched some early Python 3.5 asyncio coding style for Python 3.7+ patterns. Most notable the `loop` is only used directly if given as parameter.
aheld84
reviewed
Mar 6, 2023
Member
aheld84
left a comment
aheld84
left a comment
There was a problem hiding this comment.
I have one question and some suggestions for typos. Otherwise it looks good.
Co-authored-by: Alexander Held <aheld84@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch we can be more certain that the connection is not kept
for longer than the
read_timeout.